Ibrahim Abdelkader

Results 147 comments of Ibrahim Abdelkader

@dpgeorge Since you went through API docs, is it safe to assume that the API will be stable after those changes ? Because then I can merge (and send) other...

Rebased to fix conflicts and enabled OpenAMP for all H747 boards. Is there anything else that needs to be done here ?

Pushed a minor fix to detect if the CM4 is configured for auto-boot, via option bytes, and handle that case gracefully. Note in this case the CM4 can't be started,...

I reviewed the commits again, everything seems to be in order.

I think you may have some really outdated changes, I didn't look at the whole PR but note that `mimxrt` already has *working* WiFi and BLE support using `nimble` and...

> Since you looked at it already, can you be specific about the places were things are duplicated? I left a quick review, anything removed I think is duplicated. >...

> Thanks for the review. I was a little bit overwhelmed by the fact that git managed to merge 3 branches Yes it looked like a bad git merge. Anyway,...

``` function ci_mimxrt_build { make ${MAKEOPTS} -C mpy-cross make ${MAKEOPTS} -C ports/mimxrt BOARD=MIMXRT1020_EVK submodules make ${MAKEOPTS} -C ports/mimxrt BOARD=MIMXRT1020_EVK make ${MAKEOPTS} -C ports/mimxrt BOARD=TEENSY40 submodules make ${MAKEOPTS} -C ports/mimxrt BOARD=TEENSY40...

Oh okay first line checks out the submodules, in that case I'm not sure why it's failing.

Didn't you manage to fix that issue the last time ? Anyway, I can't reproduce this: ```bash make -j12 BOARD=arduino_nano_33_ble_sense SD=s140 FLASHER=bossac deploy MPY: soft reboot MicroPython v1.20.0-74-gff08f1efa-dirty on 2023-05-22;...