Ibrahim Abdelkader

Results 147 comments of Ibrahim Abdelkader

> the `EXTIx` fields' width varies from one product to another, being 4-bit wide for some and 8 for others. I see, that makes sense, thanks for the clarification! Well...

Does this run every time `logging` is imported ? ```python if hasattr(sys, "atexit"): sys.atexit(shutdown) ```

> No, a module is only ever executed once, the first time it is imported. So that atexit register will run only once. Yeah just wanted to double check. I...

> basic use where you just start logging doesn't work @dpgeorge Fixed, thanks. > While at it could you perhaps add @stinos Added. > If handlers are being added can...

Just a minor optimization, this will only init the root logger and only if it's not initialized. ```python def getLogger(name="root"): if name not in loggers: loggers[name] = Logger(name) if name...

> I think it should work like it did before (and hence be CPython compatible). It was Not CPython compatible because it printed a logger name, level etc.. where as...

Would it be better if https://github.com/micropython/micropython-lib/pull/508 is included in `logging` ?

@dpgeorge I tested this by adding all analog/analog-only pins to the Giga board, and I can read values independently on dual pads pins, so it seems to be working fine,...