Ibrahim Abdelkader
Ibrahim Abdelkader
@jimmo PR updated, I think I've fixed all of the minor naming, files etc.. issues in the review, if I missed something let me know. - Re libmetal, I forked...
> additionally the port-specific stuff should match the existing convention and use "mpXYZport.c". I was following how `mbedtls` is ported (i.e. `mbedtls/mbedtls_config.h`, `mbedtls/mbedtls_port.c`) but I'm okay with `mpmetalport.h`, I don't...
@jimmo > Here's an attempt at a very basic implementation of their pre-processor that allows us to use the upstream submodule. It also makes it much clearer what the minimal...
Oh okay, so it falls back to the generic version.
@jimmo > Only keep the modified files. (With the exception of log.h which could be done directly in mpmetalport.h) It doesn't build with that change, because headers include `log.h` before...
I've pushed the branch again to reword the outdated commit messages, and add a config file include for open-amp. If needed the config file will allow ports/boards to override openamp/rproc...
> (For my own curiosity, I'm still not entirely clear why the first way is needed though, i.e. what scenario does that support that wasn't possible the second way?) Although...
> @iabdalkader can you please add some initial documentation for the new `openamp` module introduced here? I can try, but the API is not finalized yet. We need to decide...
> I pushed a commit to this branch which refactors the stream seek code, and now the coverage passes because the new code is tested by existing tests. @dpgeorge Thanks!...
@dpgeorge Docs added and all CI issues fixed.