Ibrahim Abdelkader

Alright, removed `strftime.py`, moved examples to `examples/` (I added the basic test case you mentioned), reverted the change in `logging.py` (it will print `None` if there's no `strftime`). > Maybe...

> please can you add back the existing example as a separate example @dpgeorge I did, it's in `examples/example_logging_1.py` and I found some issues and fixed them. The log should...

> default argument for getLogger in CPython is None > Logger.__init__ has level as last argument > force=True does not remove all handlers it just closes them > same for...

> So I really think the minimal basicConfig implementation should at least be somewhat sound. When you first call `getLogger("root")` it sets up the root logger using the default log...

> there's a print statement in Logger, it doesn't do propagation like CPython does. However since that was already the case before this shouldn't be changed in this PR. That's...

This is a known issue with the stm32 port, CPU pins names should match the datasheet, but in the stm32 port the "P" prefix was removed to save code space,...

I understand this is a non-breaking change, and I also would like to keep `machine.Pin('Pxy')` working, as we have many scripts that use it, but at this point I'm wondering...

@dpgeorge It would be really nice if we can update the CMSIS headers to support zero and copy tables, this way I can remove the function that initializes the shared...

> > It would be really nice if we can update the CMSIS headers to support zero and copy tables > > We can. But not until after the upcoming...

Hi @jimmo Thanks for the thorough review! I'll get around to addressing all of the review comments next week, when I get back from vacation. > This would mean moving...