hvadehra

Results 96 comments of hvadehra

Allow setting rule name for analysis tests

Now that bazel 5.0 is released, this is now ready for review @brandjon

Export ProGuard specs from java_import.

Hi @cpsauer, is this something you're still looking at? (btw JavaImport and is now in Starlark: https://github.com/bazelbuild/bazel/issues/15196#issuecomment-1486891278)

JRE logs to stdout and breaks javac/scalac worker on certain environments

We're already doing that by default: https://github.com/bazelbuild/rules_java/blob/master/toolchains/default_java_toolchain.bzl#L47-L50 @ashi009 Are you using a different toolchain configuration?

Add jmods

@cushon What are your thoughts about this?

Add jmods

> Would it make sense to have something similar in rules_java (a separate target), or to add this? That sounds reasonable. @Sineaggi Could you please declare a separate java_runtime with...

Add jmods

Closing in favor of https://github.com/bazelbuild/rules_java/pull/184

Add jmods

> When can we expect a new release of rules_java containing that fix Hopefully soon, I opened https://github.com/bazelbuild/rules_java/issues/186 for now

Question: How to override the remote JDK version

This is now explained in https://bazel.build/docs/bazel-and-java#java-versions

How to use `remote_java_repository` with a JDK release where Java home is nested?

@josephglanville did https://github.com/bazelbuild/rules_java/issues/102#issuecomment-1676674836 fix this for you?

How to use `remote_java_repository` with a JDK release where Java home is nested?

Alright, feel free to ping here if this comes up again.