hvadehra

Results 96 comments of hvadehra

Looks like https://github.com/google/turbine/pull/320 made it into Turbine 0.6.0, which landed in Bazel in https://github.com/bazelbuild/bazel/commit/81117aabe22f615743a2fe01548f9764dcad8a63 Does that resolve this issue, or is there anything else we're waiting for?

@c-mita WDYT about the idea in https://github.com/bazelbuild/bazel/issues/20577#issuecomment-1883211431?

Presumably this has been fixed by https://github.com/google/turbine/pull/313 so all we need now is a turbine release and updating that in Bazel.

@Wyverald looks like this needs updating the lockfile on all platforms?

@bazel-io fork 7.2.0

> Unfortunately yes. If this PR is otherwise ready, I can start importing and fix the lockfiles on my side. Yes this is good to import , thanks!

Thanks. It looks like this is WAI. There is [some precedent](https://github.com/bazelbuild/bazel/commit/91f842130769c9123f77f6948757ef778ca6f4a4) for skipping this warning for well-known cases, but I'm not sure how well that scales for all such cases....

> I think that these warnings are emitted for java_import targets, which always use ijar. Ah, right. Is it possible to maybe wrap the corresponding source jars in a `java_library(...,...

Then maybe just build with `--nouse_ijars`? AFAICT it only applies to `java_import`. (well, also javac compilation iff header compilation is disabled).