hvadehra
hvadehra
> Is there a reason to build a fat binary and move away from the previously used pattern where 3 prebuilt repositories are released? Technically you should be able to...
#21392 looks fine to me as an improvement, but `$(rlocation local_jdk/bin/java)))` being empty is more concerning. I'm going to take a stab at trying to repro.
I tried your steps in a pristine container and everything works fine. Given that `--java_runtime_version=21` makes things work for you, does the issue also go away if you explicitly set...
Thanks for confirming. I've submitted 77c2791212ae972661231ae696d5e02a669839f0 to at least localize the reliance on local_jdk to the tests that actually make use of it. I think your change could be still...
LGTM, and I can confirm most of the regression is gone (other than the small amount caused by the new field). However since @aranguyen has an [alternative change](https://bazel-review.googlesource.com/c/bazel/+/240039) in progress,...
> Do we need to handle version-skew between Bazel and java_tools? If so, we may need to add a bit more logic to JacocoCoverageRunner? Yes, I think we need to....
Just a quick clarification before I properly review, my understanding is this change is currently doing two things: 1. Export the manifest jar path from the stub template and start...
Sorry, I guess I misunderstood your question about version skew. I meant that in `JacocoCoverageRunner` we can't assume the new variable will be available/exported. Assuming we can get this into...
@bazel-io fork 7.1.0
I think we also need https://github.com/bazelbuild/bazel/pull/19361