Herb Sutter comments

Results 316 comments of


                                            Herb Sutter

Initial clang-tidy configuration

Thanks for your pull request! It looks like this may be your first contribution to cppfront. I've emailed you the Contributor License Agreement (CLA), and once it's signed I can...

Initial clang-tidy configuration

Got it, thanks Radu!

Initial clang-tidy configuration

Looks good, we just have the reflect.h merge conflict... usually the line numbers changes don't cause a conflict, and maybe the simplest workaround is to move the reflect.h/h2 changes to...

Initial clang-tidy configuration

Thanks!

as(): make as() cast to use type_safety.enforce

Hi! Just checking in as I clean up the PRs with the relicensing (see #1322), is still intended to be still a draft PR? If so perhaps I'll close it...

as(): make as() cast to use type_safety.enforce

Hi! I haven't heard back so I'll just close this for now, but please reopen or replace with a new PR if you pick this up again. Thanks Filip!

[BUG] Cppfront can not parse "\x{62}"

Thanks! TIL: > can not parse `"\x{62}"` I wasn't familiar with that extension, and after some spelunking discovered it was added for C++23 by paper [P2290R3](https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p2290r3.pdf). It seems to be...

[BUG] Cppfront can not parse "\x{62}"

> If concat strings are output as concat strings everything is fine. My thought about that was that concat strings that don't use interpolations would be emitted as concat strings...

[BUG] Cppfront can not parse "\x{62}"

Correct, and slightly finer-grained: Cppfront couldn't use it internally because cppfront has to be compilable on pre-P2290 compilers, and cppfront couldn't emit it (unless via passthrough if originally authored by...

[SUGGESTION] can we add a way to use attributes?

Thanks for the suggestion! I haven't implemented attributes yet, but intend to.