cppfront icon indicating copy to clipboard operation
cppfront copied to clipboard

Initial clang-tidy configuration

Open farmerpiki opened this issue 1 year ago • 5 comments

This adds some configuration to clang tidy, more to come in the future as well as more fixes to the code to go along with it.

Thanks.

farmerpiki avatar Aug 21 '24 21:08 farmerpiki

Thanks for your pull request! It looks like this may be your first contribution to cppfront. I've emailed you the Contributor License Agreement (CLA), and once it's signed I can look at your pull request. Thanks again for your contribution.

hsutter avatar Aug 21 '24 23:08 hsutter

Signed.

farmerpiki avatar Aug 22 '24 00:08 farmerpiki

Got it, thanks Radu!

hsutter avatar Aug 22 '24 13:08 hsutter

Looks good, we just have the reflect.h merge conflict... usually the line numbers changes don't cause a conflict, and maybe the simplest workaround is to move the reflect.h/h2 changes to a separate PR?

hsutter avatar Sep 03 '24 22:09 hsutter

Looks good, we just have the reflect.h merge conflict... usually the line numbers changes don't cause a conflict, and maybe the simplest workaround is to move the reflect.h/h2 changes to a separate PR?

I hid the initialization thing for now cause some didn't like the immediately invoked lambda expression..., without that the line number changes are no longer an issue

I think I'll leave it until you relax the rules for out parameters.

farmerpiki avatar Sep 06 '24 19:09 farmerpiki

how can I get those workflows approved?

farmerpiki avatar Sep 13 '24 11:09 farmerpiki

I'm sure Herb is busy with CppCon right now. The conference opens tomorrow and he has the opening keynote on Monday morning.

gregmarr avatar Sep 14 '24 13:09 gregmarr

Thanks!

hsutter avatar Sep 24 '24 16:09 hsutter