Herb Sutter comments

Results 317 comments of


                                            Herb Sutter

F.6 usage of "noexcept": exclude virtual inline declarations?

Fixed in #2264.

Allow multiple calls with shared pointers arguments (not being a reference parameter) for rule R.21

Editors call: We agree the `&` should be removed. Thanks!

Proposed specification for `gsl::dyn_array`

Editors call: Thanks, looks good but please: - @GabrielDosReis add a note that by design there are no iterator/pointer-invalidating operations (other than the destructor) - ensure that there is no...

C.20 - "rule of zero" and constructor handling

Editors call: Thanks! We'll add a constructor to C.20.

Discourage implicit casting from/to void pointer

Editors call: Thanks! We think this covered as @iglesias summarizes, and the main safety concern is casting from `void*` not to `void*`.

Combine rules C.36 and C.37

Editors call: Thanks! We agree the two have the same Enforcement because we want the rules to stand on their own, but we think of C.37 as "an" implementation of...

Should SF.7 avoid to limit its applicability to when the directive is at global scope?

Editors call: Thanks! > where `innocent-header.hpp` is the only file I own We wonder if this is the problem, because all three files are adding things to a namespace and...

Change "member variables" to "[static] data members" for consistency

Resolved with the merged change.

Should/can Expects and Ensures be macros?

Editors call: We've been dragging our feet on this because Expects and Ensures were supposed to be temporary placeholders that would soon (in C++20) be made redundant by contracts. Now...

Feature to allow multiple translation unit compilations of generated pure headers

Thanks for the suggestion and investing the time to provide code! I may have cycles to take a look at this but for now I'm putting it in bucket 4...