Herb Sutter comments

Results 316 comments of


                                            Herb Sutter

Rework CI & Tests Handling

Hi! Just checking in as I clean up the PRs with the relicensing (see #1322), is still intended to be still a draft PR? If so perhaps I'll close it...

Add guideline to not invoke undefined behavior

Editors call: We think this is a promising guideline, and please iterate with @GabrielDosReis and @jwakely to make it less wordy and add some examples.

[P.6] copyedit: Move a comment for consistency, change "a" to "the", and fix a typo: "f" to "f2"

Editors call: Thanks!

[P.6] copyedit: Move a comment for consistency, change "a" to "the", and fix a typo: "f" to "f2"

Note to editors: At first I was going to keep the comment on the same line as formatted originally, and then I saw that this change makes the formatting consistent...

[BUG] Move on definitive last use in fold expressions

> Looks like there's an opportunity for improving the diagnostic here. Thanks! This part is done: 07b0eeda5e89639e355678bdee137df098902a8d

Bugfix: Update for regex 20 lookbehind test.

Thanks! I pushed a commit that re-runs the regression tests to keep everything in sync. While doing that, I noticed there seems to be a problem for MSVC here with...