Haris Sahovic comments

Results 82 comments of


                                            Haris Sahovic

Cannot upgrade poke-env

Which version of python are you running?

calc_reward passes in last_state and previous_state with the same current hp values

Hi @thekevalian, Thanks for reporting this. I'll investigate.

Misc. Gen 1 Compatability Issues

I'm closing for now - let me know if you want to reopen it :)

A whole bunch of useful improvements

I agree that the current way results are handled by player objects can be improved, but i don't think starting battles should erase the previous results. These two actions should...

A whole bunch of useful improvements

Hey @cameronangliss, I missed your comments - sorry for the delay. Thanks for this PR and good update. > A new Player method called battle_against_multi which allows you to play...

Using linux for poke env yields ConstantTeambuilder object has no attribute '_mons'

Hi @AlanOsys, Thanks for opening this issue. Can you post a minimum example to reproduce this issue?

Using linux for poke env yields ConstantTeambuilder object has no attribute '_mons'

I wonder if this has to do with carriage return (`\r\n`) v. line feed (`\n`). Most editors give you the option to choose. If yours does, can you try changing...

ValueError: Error when checking input: expected dense_input to have shape (1, 10) but got array with shape (1, 2)

Please see https://github.com/hsahovic/poke-env/issues/508#issuecomment-2054201642

Wrong shape of dense_input

Hi @Ank-22 and @snufkinnikfuns, `keras-rl` has stopped development a while ago and is hard to get running these days. There are combinations of package versions where this example works -...

Add benchmarks to CI

You are right in the sense that these integration tests make sure the code runs with a given timeout. What I would like to implement is a check that executes...