Hervé Pagès
Hervé Pagès
Changing how a SumarizedExperiment gets displayed should not be a side effect of loading the package
Not sure I understand how this would work exactly. More precisely I don't know how you can programatically distinguish between a package that lands on the search path because the...
Changing how a SumarizedExperiment gets displayed should not be a side effect of loading the package
But what if **tidyprint** ends up on the search path because another package has it in `Depends`? As I wrote earlier, I'm not sure how you would be able to...
Ok let's keep the pirate-sounding name 😃 Thanks @wolfganghuber for your feedback!
Yep, I had no idea either but I was made aware of this very recently. See https://github.com/Bioconductor/Contributions/issues/3616#issuecomment-2430877384 As you can see the workaround is _very_ easy if you can't wait...
Hi @jmitchell81, Here is some immediate feedback: 1. I still don't see any `set.seed()` calls in the HTML vignettes. 2. You still have at least one occurence of `domino2` in...
Hi @jmitchell81, Do you intend to follow up on this submission? Let me know if you have any questions. Best, H.
@jmitchell81 Thanks for these changes. Two more things and the package should be good to go: 7. You still have many occurences of "domino2" in your source code. Note that...
Thanks for the changes. Best, H.
> [@hpages](https://github.com/hpages) any input would be appreciated. I'm not familiar with the **maftools** package, sorry
Hi @kathiwaury, The package and vignette look good. Only one minor cosmetic detail. Functions print unnecessary success messages. For example: > proteinDF proteinDF proteinDF