Hervé Pagès
Hervé Pagès
So basically the proposal is to replace the `"there is no package called ‘scran’"` error message with the more user-friendly `"you don't have package 'scran'; install it with blah blah"`....
It's about installing missing packages (and the error message explicitly instructs the user to use **BiocManager** to do so), which makes **BiocManager** kind of a natural place for it.
And that work is now completed and available in Bioconductor (has been since April 28, 2020): https://bioconductor.org/packages/sparseMatrixStats Best, H.
Hi @ecool50, please address the issues reported by the automated single package builder (SPB) above, so I can start the review. Thanks!
Hi @ecool50, Please address the import issues (various "no visible global function definition for" NOTES by `R CMD check`). For the **methods**, **stats**, and **S4Vectors** imports, _full_ imports (e.g. `import(stats)`)...
Hi Laurent, Taking a first look at this, here is some immediate feedback: 1. Imports: - Importing selectively from the **methods** package is strongly discouraged. Note that you already import...
Excellent! Thanks for all the changes. Cheers, H.
Maybe but that's not really the point. To provide some context, I came across this while looking at the following issue: https://github.com/waldronlab/MultiAssayExperiment/issues/276 On a related topic I wish you didn't...
Darn, you're right! Why on earth would `validObject()` do this? `callNextMethod()` doesn't do this AFAIK. Seems totally unnecessary. Plus this coercion could be costly. Unfortunately I took for granted that...
reported https://bugs.r-project.org/bugzilla/show_bug.cgi?id=17944