Christian Hoffmann
Christian Hoffmann
@pabera Another thing which is worth mentioning after #2325 is that the new mutagen dependency will be missing by default. This crashes the player thread upon swipe: ``` Apr 14...
I've just stumbled upon this PR after playing with code enhancements around this topic myself. My current code is here and has been tested for `play_single` for now: https://github.com/hoffie/RPi-Jukebox-RFID/commit/c4805cebb848e8aaafd69c43f497b09436e67169 -...
@s-martin What would be the best way forward? Should I wait for #2164 to be merged and rebase my code on that? Or should I rather submit a PR with...
@pabera Thanks. I'll try to address your comments in my upcoming PR. I guess a PR will be easier to comment/review than a single commit (which can't change). Will probably...
> I'll try to address your comments in my upcoming PR. See #2331.
#2332 has a working attempt at implementing an idle shutdown timer. @votti > time since the playerstatus has last been not paused -> could be derived by listening to the...
> Windows JACK build failing see #3206
> MacOS Legacy build failing for dmg build. unrelated to this PR. I've tried tracking it down with no success so far.
Well, no, it doesn't seem like #2925 is sufficient to avoid this issue, see https://github.com/emlynmac/jamulus/actions/runs/3357222609/jobs/5562884622#step:10:1838
I've just commented in #2624: I think that 6h timeout is redundant now that #2927 has been merged (it drops exactly that timeout, AFAIU). That was the initial reason for...