Christian Hoffmann

Results 150 comments of Christian Hoffmann

I think the direction of the PR is fine. I haven't had a look at all details yet. By remaing files you mean the following, right? ``` $ find android/...

I fear that we would still continue to provide the legacy Mac builds, wouldn't we? If we want to continue supporting older versions, the blockers would be: - Lack of...

> There's nothing like a system("lrelease") call I think? Could we run a bash script (or extend the autobuild scripts to run lrelease before compiling) We can run system commands...

One thing to consider is that ChangeLog or CHANGELOG is a pseudo-standard name and people or tools might look for exactly that name. The Changelog is also parsed as part...

I'm all for it. In addition, people (the last one was me...) check in updated generated files by accident (still not sure which part sometimes updates them). The only thing...

I had opened a PR, but it looks like this might not work for all platforms (yet). Related: https://github.com/jamulussoftware/jamulus/pull/799 https://github.com/jamulussoftware/jamulus/issues/1304

> After updating to 3.9.0 and Qt6, the country of my server changed without any changes to the config, apparently it is using Qt6 Country IDs now. Thanks for the...

I've prepared a branch which adds support for two-letter ISO country codes here: [hoffie@serverinfo-two-letter-country-codes](https://github.com/hoffie/jamulus/pull/new/serverinfo-two-letter-country-codes) Will submit after #2829 is merged as the branch is based on that PR.

> What would happen the server you connect to runs a newer (beta) release or custom version? Would it (falsefully) show the message? For intermediate versions (any suffix after the...

> but we could introduce logging and once the client knows that multiple different servers are running a higher version, we could fire this message. Hrm, I think this would...