Christian Hoffmann

Results 150 comments of Christian Hoffmann

@ncabatoff Friendly ping -- is there anything I can do/improve to get this into a mergable state? (I'm fully aware that reviewing pull requests does need time and energy and...

Meh, problems here as well: something (brew?) doesn't support xcode 11.7. :( https://github.com/hoffie/jamulus/actions/runs/3365069827/jobs/5580149907#step:10:1427 Maybe we can try an older brew or switch xcode right before the create-dmg step. The legacy...

That's probably the problematic check: https://github.com/Homebrew/brew/blob/master/Library/Homebrew/os/mac/xcode.rb#L363 We could workaround that by switching to a more recent xcode for brew/create-dmg stage. I've tried that here: https://github.com/hoffie/jamulus/actions/runs/3369510835 Can someone test if the...

Previous artifacts expired, I've kicked off a new run here: https://github.com/hoffie/jamulus/actions/runs/3492108643

Lot's of relevant changes can be taken from #2909 (contributed by @danryu).

I've just added a related function for adjusting the URL scheme in v1.1.12 (via a URL parameter, which allows for per-request decisions). It does not have proper certificate validation yet...

See https://github.com/jamulussoftware/jamulus/pull/2625#issuecomment-1275690542: > `QMAKE_LFLAGS += -Wl,-e,_qt_main_wrapper` Thanks to @danryu.

@pabera Yes, I've seen the existing timer classes. However, I've had a hard time seeing how they could add benefits here. Two use cases come to mind: - Could the...

> I am missing concrete instructions know how to actually fix this issue on my current installation. Here is what I did: **Use system lgpio (because the version on pypi...

> @hoffie, did you make a PR to the rc522, so this fix may be included? Not yet, because the changes seemed a bit too fundamental. I'll try to find...