jamulus icon indicating copy to clipboard operation
jamulus copied to clipboard

[DISCUSSION] move OS related files out of platform specific folder

Open ann0see opened this issue 2 years ago • 4 comments

Short description of changes

DO NOT MERGE!

Context: Fixes an issue? No. Just moves files out of the platform specific folders into src/res, libs/ or specific folders in src/.

Does this change need documentation? What needs to be documented and how?

Status of this Pull Request

Ready for discussion what we should do with the remaining files.

What is missing until this pull request can be merged? Testing and discussion.

Checklist

  • [x] I've verified that this Pull Request follows the general code principles
  • [ ] I tested my code and it does what I want
  • [x] My code follows the style guide
  • [x] I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • [ ] I've filled all the content above

ann0see avatar Apr 17 '22 18:04 ann0see

@hoffie you requested this PR a while ago, and I think it makes sense discussing the moving of files. I'm not yet done fully with moving everything out, but I think it's a good start?

ann0see avatar May 16 '22 21:05 ann0see

I think the direction of the PR is fine. I haven't had a look at all details yet.

By remaing files you mean the following, right?

$ find android/ mac/ ios/ linux/ windows/ -type f
android/res/drawable-xhdpi/icon.png
android/res/drawable-mdpi/icon.png
android/res/drawable-xxxhdpi/icon.png
android/res/drawable-hdpi/icon.png
android/res/drawable-ldpi/icon.png
android/res/drawable-xxhdpi/icon.png
android/AndroidManifest.xml
mac/Info-make-legacy.plist
mac/Info-make.plist
mac/deploy_mac.sh
mac/Jamulus.entitlements
mac/Info-xcode.plist
ios/deploy_ios.sh
ios/Info.plist
linux/deploy_deb.sh
windows/deploy_windows.ps1
windows/installer.nsi

I don't have a good idea for those yet. Moving all build scripts to build/ or something would still leave some stuff. Would generic platform/ directory make sense to reduce the number of top level directories at least?

hoffie avatar May 19 '22 20:05 hoffie

Yes. Some of these files can easily be moved (.entitlements etc) but the build scripts? I'm not sure if the windows build version creates a folder called build during compile time, so not sure...

ann0see avatar May 21 '22 05:05 ann0see

I think it might make sense to open separate PRs with only a few of these commits such that testing becomes easier…

ann0see avatar Aug 06 '22 10:08 ann0see

Ok. Now the most "dangerous" PRs are missing: images and distribution moving.

ann0see avatar Sep 02 '22 08:09 ann0see

Closing since https://github.com/jamulussoftware/jamulus/pull/2838 is the last one related to this PR.

ann0see avatar Sep 06 '22 18:09 ann0see