hillarymarler
hillarymarler
Maybe that param should be included in both TADA_CreateUnitRef and TADA_ConvertResultUnits? Because if the user does not supply their own ref, then TADA_CreateUnitRef is used in TADA_ConvertResultUnits to creat the...
An additional improvement that could be considered for this function is to write an internal function that would handle the plotting of depth unit characteristics vs. other characteristics. This would...
@wokenny13 - tagging you in case the looping approach you would like to investigate for the grouped scatterplot may be useful here too.
That sounds like a great solution! Is PR #522 ready for review or are there still additional changes you would like to make first?
This is ready for review. If you spot any additional places where I have not made the MonitoringLocationIdentifier -> TADA.MonitoringLocationIdentitifer switch.
Closing this PR. Will resubmit when I have a working draft involving the geospatial components we've discussed in Team meetings.
Thanks, @kathryn-willi!
@cristinamullin - the reason I had left the units in the TADA_CreateUnitRef output was for cases where a user might want to convert to a unit that we don't have...
For a short term fix, to address just the issue of the checks failing related to vignettes requiring the NHDPlus_HR.MapServer, switching the vignette to an article (which is still displayed...
https://r-pkgs.org/vignettes.html#sec-vignettes-article " An article will be less accessible than a vignette, for certain users, such as those with limited internet access, because it is not present in the local installation....