hillarymarler comments

Results 82 comments of


                                            hillarymarler

Add media to unit conversion template

I will work on this as a separate pull request after closing #619

ActivityStartDateTime, time zones, and offset cols

I like the idea of a separate time zone code column. As you note, this seems like it would be much less likely to impact existing workflows.

ActivityStartDateTime, time zones, and offset cols

Ideas from working group call: include both original sample local time and UTC Local time might allow for better comparisons across tz (depending on what is being compared) - for...

TADA_AnalysisDataFilter removes rows when clean = TRUE if TADA.UseForAnalysis.Flag == "No - NA"

Is this something that needs to be completed prior to Cybertown?

TADA_AnalysisDataFilter removes rows when clean = TRUE if TADA.UseForAnalysis.Flag == "No - NA"

Great! I will work on a fix after the workshop.

Flag column values are inconsistent (Rejected, Invalid, Suspect vs. Accepted, Valid, Pass)

@wokenny13 - we will definitely want to communicate with them as we make updates. Also, with the team that is working on a similar tool for AK.

TADA_FlagContinuousData and TADA_FindPotentialDuplicatsMultipleOrgs bugs: NAs showing up in flag columns

I can work on this one next, since I’m kind of on hold on the range check stuff until we can discuss at the WQX meeting.

TADA_FlagContinuousData and TADA_FindPotentialDuplicatsMultipleOrgs bugs: NAs showing up in flag columns

This appears to have been addressed in PR #560

search within Assessment Units in TADA_FindNearbySites

Related to https://github.com/USEPA/EPATADA/issues/660

Assign different censored data handling methods to different characteristics

I'd like to work on this. We can discuss priorities and when I should start on it.