hillarymarler
hillarymarler
I think other characteristics in the "Physical" characteristic type group should be reviewed as well.
@cefergus and @wokenny13 - should suspended fraction pH results be harmonized with all other pH results? This is the current harmonization table, where the included instances for pH all assume...
I found the "suspended" pH results in a test data set I downloaded from the WQP (see first post in this issue). There are quite a few combinations of characteristic/fraction/speciation...
I'm interested in helping with this one if it is still in need of additional development after I finish working on vignettes for upcoming presentations.
@cristinamullin - it would make sense to work on this along with the pH harmonization issues (https://github.com/USEPA/TADA/issues/454)
I've been spending some time this morning looking at the IL example Cristina included above as well as some other examples. I am still seeing similar issues on some data...
Is this something we should work on when 3.0 profiles are finalized?
Would we only want to use this map for querying the WQP? Or should it be usable for filtering after data retrieval as well?
@wokenny13 - is this one you might be interested in working on?
This is a comment from @cefergus's review of https://github.com/USEPA/EPATADA/pull/501 (continuous data flagging updates) > I think the revised function looks good from what I could see. I ran the revised...