Update to WQX ref (ft, in, m) and TADA (mass/mass to mass/volume) ref

[wokenny13]

Kevin has updated the WQX ref to reflect the changes. We decided to keep target units to inches, and fixing those 3 rows for the conversion factors.

I've added additional rows in TADA.PriorityCharConvertRef for common mass/mass to mass/volume conversions.

I ran a random testing TADA_DataRetrieval and found a #/100mL unit with no conversions to CFU/100mL, and added on this as a row to TADA.PriorityCharConvertRef in the csv.

Checking the conversion factors for reasonableness will be good for review, and if these additional rows make sense.

[cristinamullin]

The unit conversions (output from TADA_ConvertResultUnits) and the TADA version of the WQX unit reference table look good now. However, the output df from TADA_CreateUnitRef still does not reflect the correct conversion factor (TADA.WQXUnitConversionFactor). See test2 output below.

I am sure this can be fixed (ran out of time today), but I was also thinking that it might not be necessary to include the conversion factors and coefficients in the table produced by TADA_CreateUnitRef, since that information is available to users if they want it via TADA_ConvertResultUnits when transform = FALSE. Either way, it looks like TADA_CreateUnitRef needs additional review/updating to finish off this issue.

` test <- TADA_DataRetrieval( startDate = "2020-01-01", endDate = "null", countrycode = "null", countycode = "null", huc = "null", siteid = "null", siteType = "null", characteristicName = "Depth, bottom", characteristicType = "null", sampleMedia = "null", statecode = "null", organization = "null", project = "null", providers = "null", applyautoclean = FALSE )

test2 <- TADA_CreateUnitRef(test)

test3 <- TADA_ConvertResultUnits(test, transform = FALSE)

test4 <- TADA_ConvertResultUnits(test) `

Note: I addressed a few other issues as part of the PR:

• Updated TADA_FlagResultUnit so it can now run without autoclean being run first
• I found that PPM was "Accepted" unit for "Depth, Bottom". Changed this to "Rejected" in WQX validation table. Reviewed many other depth result units as well & updated the WQX validation table for those as part of this update.
• Updated reference tables and example data again
• Removed TADA.WQXTargetUnit and added TADA.Target.ResultMeasure.MeasureUnitCode to required cols
• Updated ordering of columns and comparable data ID when transform = FALSE
• Adds TADA.WQXUnitConversionCoefficient and TADA.WQXResultUnitConversion to column ordering (only relevant when transform = FALSE)
• Updated documentation

[hillarymarler]

@cristinamullin - the reason I had left the units in the TADA_CreateUnitRef output was for cases where a user might want to convert to a unit that we don't have in the unit refs. But if that scenario is not going to happen (or extremely unlikely), then I agree we can remove those columns as users can access the conversion info through TADA_ConvertResultUnits when transform = FALSE.

@wokenny13 - do you want to work on the updates needed for TADA_CreateUnitRef? Or would you like me to do that?

[wokenny13]

test <- TADA_DataRetrieval( startDate = "2020-01-01", endDate = "null", countrycode = "null", countycode = "null", huc = "null", siteid = "null", siteType = "null", characteristicName = "Depth, bottom", characteristicType = "null", sampleMedia = "null", statecode = "null", organization = "null", project = "null", providers = "null", applyautoclean = FALSE )

@hillarymarler I can work on making these updates. I will let you know if I have any questions as I catch up on these comments.

[wokenny13]

@hillarymarler @cristinamullin

• Updated list of mass/mass to mass/volume TADAPriorityCharConvertRef.csv units to be converted to mg/L and UG/L.
• Rearranged columns of output for TADA_CreateUnitRef. Keeping in the Conversion Factor and Coefficient but hope to make it clear which columns are being referenced with this rearrangement.
• Included the updates to test-that CriteriaComparison.R in this pull request - see comments in #525

[cristinamullin]

These updates look great - thank you @wokenny13! I just merged in updates from develop. Once the checks complete, it can be merged in.