hhugo
hhugo
@rgrinberg, this is ready
> The issue is that the Wasm code is fetched and compiled asynchronously. So the `load` event has already been triggered when the code is executed. This does not happen...
> This PR looks like it contains some formatting changes (using arrow functions) and also rewrites some of the most foundational primitives in the jsoo runtime. Could you split these...
> To fix the noArguments, you need the arrow function, and to fix the useArrowFunction, you need to remove the arguments... I don't see the relation, sorry. I would expect...
> After asking for the PR to be split up, I did the benchmarking which has me pretty confident that the change should instead be abandoned, so I don’t want...
@TyOverby, Have you run more that just micro benchmarks ? Were you able to see differences with real applications ?
> I haven’t run this on any real applications because we aren’t easily able to pull in jsoo branches until wasm is merged. However, i think that microbenchmarks are sufficient...
> FWIW, I find the new style of code in this PR to be harder to read than the original, so without a good reason to do it (like performance),...
rebased
You shouldn't use Fpath.to_string when generating path in dune files.