Jsoo shapes

Open hhugo opened this issue 1 year ago • 2 comments

corresponding PR https://github.com/ocsigen/js_of_ocaml/pull/1594

The next release of Js_of_ocaml will be able to do some cross-module/cross-library optimization. Dune needs to be explicit about additional dependencies.

Jul 26 '24 12:07 hhugo

@vouillon, can you take a look ?

Jun 11 '25 15:06 hhugo

@hhugo As far as I understand the code, we are only reading shapes from cma files, not from cmo files. Should we use Compilation_context.dep_graphs for that?

Jun 18 '25 17:06 vouillon

@hhugo As far as I understand the code, we are only reading shapes from cma files, not from cmo files. Should we use Compilation_context.dep_graphs for that?

I've just pushed the fix.

Jun 19 '25 07:06 hhugo

@vouillon, can you review this again ? I've addressed your comments.

Jun 26 '25 08:06 hhugo

ping @vouillon

Jul 04 '25 10:07 hhugo

@rgrinberg, this is ready

Jul 08 '25 10:07 hhugo