Update ocaml/setup-ocaml to v3

Open smorimoto opened this issue 1 year ago • 4 comments

Jul 02 '24 04:07 smorimoto

If I understand correctly the setup-ocaml release changelog, this setups ocaml with opam 2.2 for windows support? Would that enable windows CI testing? That would be great!

Jul 02 '24 09:07 panglesd

I added Windows, but it seems to fail due to the path delimiter, etc.

Jul 02 '24 12:07 smorimoto

You shouldn't use Fpath.to_string when generating path in dune files.

Jul 03 '24 05:07 hhugo

Ready to go!

Aug 05 '24 20:08 smorimoto

@panglesd Ready to go!

Nov 10 '24 04:11 smorimoto

Thanks! I commented the windows matrix entry: We don't have a plan to fix the tests on windows in the (very) short term, there is no point in running them just to ignore them. But thanks to you, they are now very easy to add as soon as we start working on them!

Nov 12 '24 08:11 panglesd

OK!

Nov 12 '24 08:11 smorimoto