hhugo
hhugo
@OlivierNicole, @vouillon, I'm tempted to introduce a dedicated type & module for target int. What do you think ? See https://github.com/ocsigen/js_of_ocaml/pull/1693
@OlivierNicole @vouillon I've rebased and adapted https://github.com/ocsigen/js_of_ocaml/pull/1693.
@OlivierNicole, what's the next step for https://github.com/ocaml-wasm/wasm_of_ocaml/issues/47
I'd like to benchmark this change
> One should create the encoder and the decoder only once and reuse it, and use a fixed buffer for `caml_jsstring_of_string`. Done
@vouillon, any idea on how to benchmark this other that micro benchmarks ?
A quick micro benchmark show a significant slowdown. master > n: 3, 0.167000 n: 7, 0.268000 n: 10, 0.371000 n: 20, 0.811000 n: 50, 1.989000 n: 100, 3.618000 this PR...
@vouillon, do you have any opinion on this ?
> Was this slowdown mitigated, or was the end decision to go with it? The slowdown should only affect non-ascii strings. Also, my assumption was that conversions between js and...
Turning the PR into a draft until the underlying PR is merged.