Sam MacPherson
Sam MacPherson
I've implemented all the requested changes except for the removal of the arbitrary length. On line 236 you can see that `NumCacheLines = (int)Math.Ceiling((double)length / IntsPerCacheLine);` makes it so there...
I see what you mean now. I can split the code into `NativePerJobThreadIntArrays` and remove `length` from the `NativePerJobThreadIntPtrs` constructor. Would you prefer a separate PR for `NativePerJobThreadIntArrays`?
Sounds good to me. I'll make the name switch.
Tested on my largest project. Works fine.
Just tested on one of our larger repos. Works fine.
We still haven't switched to Foundry deployment yet. It's one of the last things we are still using dapp tools for. Will test these features when we switch over, but...
Finally got around to testing this. With [this PR](https://github.com/makerdao/dss-bridge/pull/2) I'm seeing a non-descript error. Running: `forge script script/DeployExistingTokenBridge.s.sol:DeployExistingTokenBridge --use solc:0.8.14 --rpc-url $ETH_RPC_URL --broadcast --verify -vvvv` Which produces: ``` The application...
As I said in our Discord chat, I updated to latest here and it seems to work fine now, so not sure what happened. Appears to work great now!
Open to either way as long as we can get the vow accounting address to be constant. I'll see about mocking up the alternative.
> If proxy is necessary, shouldn't EIP-1967 Transparent Proxy pattern be used ? I am following the long MakerDAO history of rolling everything ourselves. Kidding aside, this is similar to...