Sam MacPherson

Results 72 comments of Sam MacPherson

Sure, but I have `ETHERSCAN_API_KEY` set in my environment all the time for easy use of cli. It's counter-intuitive to have this be silently overriding the config file.

> Setting an ENV value always does this this is standard Ok, but it doesn't make any sense intuitively. Why should a global API key value override network-specific configured ones?

TBH I use void promises all the time. Very useful if you are only interested in the success or failure of an operation. My quick solution was to just define...

I would return a rejected promise from the errorPipe to do that behaviour. Although I agree regular exceptions thrown from catchError/errorThen/errorPipe should enter the regular promise exception flow.

I am talking about taking a CPU profile on the chrome dev tools. The overhead from the polyfill may go away if the functions are optimized, but I did not...

After thinking on this some more the issue is not so much about environment preference ordering. It's more that specifying a global etherscan api key doesn't make sense when doing...

Ok can close this if need to work around with a different environment configuration.

Yeah I was thinking of the function overloading. There seems to be a lot of it in node, and I couldn't really come up with a solution off the top...

I've been thinking about the macro build feature some more, and I think it might be worthwhile to have a Node package pre-built with all callback-style functions converted to promise-style...

Will be adding overload support pending this issue getting implemented https://github.com/HaxeFoundation/haxe/issues/3460