Mark A. Hershberger

Support external tools to supply fixups

1

PHP CodeSniffer (phpcs) is integrated with FlyCheck. Some of the issues it finds can be fixed with phpcbf. It would be nice if this tool could get the fix needed...

Add require for compile

3

Otherwise, if the user hasn't already loaded compile for some reason, an error will result.

Add error checking

1

* Prompt for missing packages at the beginning of the build. * Re-use netboot.iso if it exists.

segfault when opening org-file

3

Was able to produce under gdb: Segfault: ``` Thread 1 "remacs" received signal SIGSEGV, Segmentation fault. hash_lookup (h=0x3b92700, key=0x1585fd3 , hash=0x7fffffff7958) at fns.c:1835 1835 for (i = HASH_INDEX (h, start_of_bucket);...

SMW needs to review the new MW hook strategy

1

### Issue The [hook interface is changing](https://www.mediawiki.org/wiki/Manual:Hooks#Handling_hooks_in_MediaWiki_1.35_and_later) in core MW and SMW will need to adapt. From TFM: > MediaWiki 1.35 introduces a system for handling hooks based on individual...

TypeError: Argument 2 passed to SMW\Services\ServicesFactory::newParserData() must be an instance of ParserOutput, bool given

6

### Setup - SMW version: 4.0 - MW version: 1.36 - PHP version: 7. ### Issue From [ci](https://github.com/SemanticMediaWiki/SemanticMediaWiki/runs/4754073283#step:10:1206): ``` File Upload Integration (SMW\Tests\Integration\MediaWiki\Hooks\FileUploadIntegration) ✘ File upload for dummy text file...

Call to a member function newSchemaList() on null

2

### Setup - SMW version: master ### Issue ``` Sub Semantic Data (SMW\Tests\DataModel\SubSemanticData) ✔ Can construct [0.03 ms] ✔ Add sub semantic data [0.18 ms] ✔ Add sub semantic data...

File Upload Integration test fails on MW 1.36

4

Test output from [ci](https://github.com/SemanticMediaWiki/SemanticMediaWiki/runs/4694964979?check_suite_focus=true#step:10:3340): ``` File Upload Integration (SMW\Tests\Integration\MediaWiki\Hooks\FileUploadIntegration) ✘ File upload for dummy text file [193.21 ms] │ │ TypeError: Argument 2 passed to SMW\Services\ServicesFactory::newParserData() must be an instance...

SMW\SQLStore\EntityStore\IdChanger->change() creates duplicate smw_di_wikipage rows

4

### Issue While running rebuildData.php RedirectUpdater's [moveAsRedirect()](https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/91546f4c02af0409f97bacecd142a6170d78cde2/src/SQLStore/RedirectUpdater.php#L561) calls [IdChanger->change()](https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/91546f4c02af0409f97bacecd142a6170d78cde2/src/SQLStore/EntityStore/IdChanger.php#L166) to update the ids in `swm_di_wikipage`. This causes problems on when you [add a hook to create indexes](https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/master/docs/examples/hook.sqlstore.installer.beforecreatetablescomplete.md) which is necessary...