Mark A. Hershberger

Results 49 comments of Mark A. Hershberger

The FSF should already have a copy of a copyright assignment on file for me. Will that do?

It looks like the failing checks here have something to do with compiling emacs, not this patch.

To do this, enableSemantics() will disappear. Is that acceptable?

> looks impossible Agreed. But [it is happening](https://github.com/SemanticMediaWiki/SemanticMediaWiki/runs/4750905875#step:10:155) somehow. Interestingly, changing the [typehint for newSchemaFinder](https://github.com/SemanticMediaWiki/SemanticMediaWiki/pull/5195/commits/1760dfd3175ee6a0cd4cf76fa5c6a66e2fb786ff) moves the failure [down a few lines](https://github.com/SemanticMediaWiki/SemanticMediaWiki/runs/4753611561#step:10:155) because now [newSchemaList](https://github.com/hexmode/SemanticMediaWiki/blob/1760dfd3175ee6a0cd4cf76fa5c6a66e2fb786ff/src/Schema/SchemaFinder.php#L123) is providing null. The signature...

@mwjames sorry I missed this earlier. This was part of a discussion that led to the [Hybrid extension management RFC](https://phabricator.wikimedia.org/T250406) where I would really like to get your input. (In...

Result of `tests/phpunit/phpunit.php extensions/SemanticMediaWiki/ 2>&1 | tee output.txt`: [output.txt](https://github.com/SemanticMediaWiki/SemanticMediaWiki/files/7365704/output.txt)

Just saw this myself. Thanks for filing the bug.

Reverting the commit that @thomas-topway-it identified, fixes the problem.

> `LocalMessageProvider` does not seem like a good place to put this. Is an entirely different responsibility by the looks of it. Should I just use MW's context object?

> (I do not really understand what you have in mind with context object) I was thinking about how to get the value of wgMessagesDirs -- but I meant [Config](https://www.mediawiki.org/wiki/Manual:Config.php),...