Hennadii Stepanov
Hennadii Stepanov
> Is the changes to the arguments we call the cli tool required here? With no changes: ``` $ ../bitcoin-maintainer-tools/update-translations.py It doesn't make sense to use the '--all' or '--language'...
@MarcoFalke @fanquake As https://github.com/bitcoin/bitcoin/pull/26321 has been merged and backported into 24.x and 23.x, this PR should be merged as well.
Concept ACK.
It is possible now to cleanup the `.gitignore` file: ```diff --- a/.gitignore +++ b/.gitignore @@ -44,8 +44,6 @@ coverage.*.html *.gcno *.gcov -src/libsecp256k1-config.h -src/libsecp256k1-config.h.in build-aux/ar-lib build-aux/config.guess build-aux/config.sub @@ -60,5 +58,4 @@...
GCC throws multiple `-Wmissing-field-initializers` warnings with this code.
> Which version of GCC and what are the steps to reproduce? Debian 11 + gcc 10.2, Ubuntu 22.04 gcc 11.3: ``` $ ./autogen.sh $ ./configure $ make clean $...
> Would be happy to re-review if changed like discussed in: [#603 (comment)](https://github.com/bitcoin-core/gui/pull/603#issuecomment-1292246325) So would I :)
> @luke-jr do you want to respond to suggestions here? Or would you be open to a someone making a new PR? I'm going to close this, and mark "Up...
> @hebasto happy for this to be merged as-is? Yes.
nit: I found the change type order [here](https://keepachangelog.com/en/1.0.0/#how) more preferable. Maybe follow it and reorder in our CHANGELOG.md as well like that: - Added - Changed - Deprecated ?