Hennadii Stepanov

Results 1437 comments of Hennadii Stepanov

> I can tell they're not Windows specific. True.

> Wouldn't this be better in two separate PR's? > > I realise the code changes are trivial but as far as I can tell they're not Windows specific. It...

Changes in `src/bech32.cpp` has been split into #26252. Touching consensus code for the sake of a MSVC warning does not look worthy, although making an `enum opcodetype` underlying type explicit...

> > But most CI checks are failing with an unclear message. > > I think it needs to be rebased. > ... but some older CI distros have a...

> Looks like the minimum git to make the merge is 2.33. But the PR itself is fine as-is, and once merged won't be a problem even for old versions...

> > It appears, it is a problem as now the CI linter job fails. > > ??? Looks like it's working fine to me? https://cirrus-ci.com/build/5775460305993728 Don't hesitate to look...

> we'll be able to prune another ~80 Boost headers from our depends bundle. Concept ACK on it.

> This reverts [ee7b84e](https://github.com/bitcoin/bitcoin/commit/ee7b84e63cbeadd5e680d69ff0548275581e9241) from #20527. > That change was made without any rationale That is untrue. Besides #20527 description. one could refer #20498. Build docs implied that Bitcoin Core...