Hennadii Stepanov
Hennadii Stepanov
> Tried to fix the MSVC issues... let's see what CI says. > > See commit messages. I verified locally that static linking doesn't break and just outputs a warning....
> For macOS, we need to take also #1153 into account. It seems that [GitHub-hosted macOS runners are on x86_64](https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources). The good news is that Valgrind should work again then......
> > moving everything to GitHub Actions is a bit cleaner for us > > Sounds interesting. I wonder how (and if) docker images can be cached, along with ccache,...
> * [ ] Move native Windows tasks to GitHub Actions (solved by [ci: Run "Windows (VS 2022)" job on GitHub Actions #1389](https://github.com/bitcoin-core/secp256k1/pull/1389)) > * [ ] Move native macOS...
> * [ ] Move Linux tasks to the Bitcoin Core persistent workers It seems reasonable to split this task in two ones, depending on the underlying architecture: `x86_64` and...
> * [ ] Enable Valgrind on macOS again now that the macOS tasks run on x86_64 ([Constant-time tests on macOS #1151](https://github.com/bitcoin-core/secp256k1/issues/1151)) While it worked on macOS Catalina back in...
> Have you tried the supplied suppression file ([LouisBrunner/valgrind-macos@`main`/darwin19.supp](https://github.com/LouisBrunner/valgrind-macos/blob/main/darwin19.supp?rgh-link-date=2023-08-25T08%3A29%3A18Z))? Yes, I have. It does not change the outcome. UPD. I used https://github.com/LouisBrunner/valgrind-macos/blob/main/darwin22.supp as we run Ventura.
> Do you think maintaining the suppressions is a problem? I don't think it's a big deal. You mean, in this repository?
> > * [ ] Enable Valgrind on macOS again now that the macOS tasks run on x86_64 ([Constant-time tests on macOS #1151](https://github.com/bitcoin-core/secp256k1/issues/1151)) > > While it worked on macOS...
> I can take care if you don't have the bandwidth. It would be nice because I have no x86_64 macOS Ventura available.