Hennadii Stepanov

Results 1306 comments of Hennadii Stepanov

> > Not sure about this issue, or making this change. Looks like it needs more investigation. See my comment here: [#30978 (comment)](https://github.com/bitcoin/bitcoin/issues/30978#issuecomment-2388086723). > > Yes, switched to draft until...

@kevkevinpal I didn't notice that https://github.com/bitcoin/bitcoin/pull/30902 overlaps with this PR. Feel free to pick all changes from https://github.com/bitcoin/bitcoin/pull/30902 to let me close it. UPD. Please separate CI changes into a...

> Where/why is this an issue? I faced this issue during my work on the CMake staging branch when the `CC` environment variable was defined by the CI -- https://github.com/hebasto/bitcoin/actions/runs/8822538616/job/24220973382....

> > The log shows no cross-compiling, but it is cross-compiling to `i686-pc-linux-gnu`. > > Can you link to the exact lines in the log that show "no cross-compiling". https://github.com/hebasto/bitcoin/actions/runs/8822538616/job/24220973382#step:14:245:...

> A better diff might be something like: > ... > which would at least be using the option that is meant to be used for this. I agree. Implemented....

> Is this still an issue given recent CMake changes? Yes. Tested with the master branch @ 80bdd4b6beb878c95478b5623c9f9ff0b948ad57. And this PR still fixes it.

> @hebasto can you rebase this? Rebased.

My Guix build: ``` aarch64 a2d14a22db6670a4f33aa4a7f9bd04d45cb861993b51670c4c950bf98f68864f guix-build-707d65ba0d74/output/aarch64-linux-gnu/SHA256SUMS.part 71d45a6c783b287a3369503b34ef08a42b5c4a2c8c2f636cf4665574e4f2f0ac guix-build-707d65ba0d74/output/aarch64-linux-gnu/bitcoin-707d65ba0d74-aarch64-linux-gnu-debug.tar.gz 3f5fb049c4347d25c091ec4412dfb3a9a6488a28aad2cca7bd52d822ff6b5f0f guix-build-707d65ba0d74/output/aarch64-linux-gnu/bitcoin-707d65ba0d74-aarch64-linux-gnu.tar.gz bb8a6a2aa57ea0d7e26523bd0d9bfd32416c31e3e0f7f1facc237f70c1528b16 guix-build-707d65ba0d74/output/arm-linux-gnueabihf/SHA256SUMS.part abd7c08544aaf6c1c3538a8cdd551eec9e545eac0f2fdaf036d1cf99e6e62933 guix-build-707d65ba0d74/output/arm-linux-gnueabihf/bitcoin-707d65ba0d74-arm-linux-gnueabihf-debug.tar.gz c1a542509b91945b679e520ff398bee9c3d66e94a3a1c356209b88290ae1202e guix-build-707d65ba0d74/output/arm-linux-gnueabihf/bitcoin-707d65ba0d74-arm-linux-gnueabihf.tar.gz c383ab8414f738ac152cfbc8c273bb224593854d605ecd3317f9d4485c672aa1 guix-build-707d65ba0d74/output/arm64-apple-darwin/SHA256SUMS.part 9321290cd61e8c11aa46fa68130011362cc2d0a4d6d89520294f255c2de90dde guix-build-707d65ba0d74/output/arm64-apple-darwin/bitcoin-707d65ba0d74-arm64-apple-darwin-unsigned.tar.gz 53e9e64ae7f34c19b56528245554a90005ef25af28ef5971eaecb002c821d87c guix-build-707d65ba0d74/output/arm64-apple-darwin/bitcoin-707d65ba0d74-arm64-apple-darwin-unsigned.zip 1012af184f40d376e3807ee07f4c12b67a1ccaf43ee469d36b0cb4d2d989a53c guix-build-707d65ba0d74/output/arm64-apple-darwin/bitcoin-707d65ba0d74-arm64-apple-darwin.tar.gz e725088b69b7f8e1332e488bf0950f1f39ccbb70c632b73dd6548a55861a8efa guix-build-707d65ba0d74/output/dist-archive/bitcoin-707d65ba0d74.tar.gz 881cc54f072595aee80e3e6557ff69d273e212ff5b9dec01eab2b26b15f5ae7a guix-build-707d65ba0d74/output/powerpc64-linux-gnu/SHA256SUMS.part 00937e24253737195ddea04e2305c2e1eebff95152409b23ad39aa645cbd5787...

@theuni > > However, switching the CC variable context from Makefile to the shell environment breaks expectations > > Arguably that's because this wasn't intended to be supported :) >...

Rebased to resolve the conflict with the merged bitcoin/bitcoin#30584.