Hennadii Stepanov

Results 1237 comments of Hennadii Stepanov

My Guix build: ``` aarch64 ab623f96d21b9651618ccd3dd1dd547494ecbe199cf1146dfebde4d02cd141a4 guix-build-38d13e68e276/output/aarch64-linux-gnu/SHA256SUMS.part 1f70c006d53d319ebbfb915a909419d5084489e527c8cf24369f113c96705251 guix-build-38d13e68e276/output/aarch64-linux-gnu/bitcoin-38d13e68e276-aarch64-linux-gnu-debug.tar.gz ae9eb92cdd2eee116bd48199ee9d8093082f58ce158badd47aaaa3cd044d2d9a guix-build-38d13e68e276/output/aarch64-linux-gnu/bitcoin-38d13e68e276-aarch64-linux-gnu.tar.gz 31c6976e87e9d1e87759ab3057f2c75eb5ed824e0a986a8317dd7b9bcd0d8fa7 guix-build-38d13e68e276/output/arm-linux-gnueabihf/SHA256SUMS.part 2a3ac0e4368c9d83419539db88a886e4f49ad93e67bf6bcc78d88c4118ab40c7 guix-build-38d13e68e276/output/arm-linux-gnueabihf/bitcoin-38d13e68e276-arm-linux-gnueabihf-debug.tar.gz 2a5e990b3c3c236bcfe720d526dbf2a319d15eba81591d280aad15c746511bb9 guix-build-38d13e68e276/output/arm-linux-gnueabihf/bitcoin-38d13e68e276-arm-linux-gnueabihf.tar.gz c5d8de4a45ed34f3cce046a540421fc05ab0f98937479afe279f645522e5d961 guix-build-38d13e68e276/output/arm64-apple-darwin/SHA256SUMS.part f12c6ca851f7f1bc88ed8f31aa87cf10aad84974eceab20e463de91ef3508142 guix-build-38d13e68e276/output/arm64-apple-darwin/bitcoin-38d13e68e276-arm64-apple-darwin-unsigned.tar.gz 0e03be196c8d5a40e0fd8cfa397e19f0d61f14fb8ff2ab50bf90a06289b2362d guix-build-38d13e68e276/output/arm64-apple-darwin/bitcoin-38d13e68e276-arm64-apple-darwin-unsigned.zip c3705df317214be53b9360f91ca9a4c1721c6bb4dad75cc348afb19d3f5c3858 guix-build-38d13e68e276/output/arm64-apple-darwin/bitcoin-38d13e68e276-arm64-apple-darwin.tar.gz db57e79fd0d357b99d8d4e762806933ac93d464f19f66b050c9cbe5f52250ab6 guix-build-38d13e68e276/output/dist-archive/bitcoin-38d13e68e276.tar.gz c221715291996b44d6f4b23afb9add05987d50936d0f52fda64d5ee8410b3806 guix-build-38d13e68e276/output/powerpc64-linux-gnu/SHA256SUMS.part 3c5f3605d0905db76d79fdb84732e0966847c49e0ce0bf676e21c8ba57a1043f...

> What was your intention with this patch, @fanquake ? @fanquake Can you please follow up here?

> I don't understand this change. It seems setting CC_FOR_BUILD to CC is exactly the opposite of what we want to do? > > @hebasto's original change makes more sense...

> However that isn't always true. If, for example, depends is built with `DEBUG=1`, and CMake is configured with `-DCMAKE_BUILD_TYPE=Debug`, `-O1` will actually be used. I think we should first...

> > Resolves #30876. > > Not sure it does, as that issue applies to all dependencies, not just ZMQ. Clarified.

> Concept ACK and quick review ACK. > > Tested with depends and verified that the fallback isn't used: [theuni@d98c76c](https://github.com/theuni/bitcoin/commit/d98c76c69e01ddacc79974fef6f7fd0f9df5ddcc) > > @hebasto want to pull that in here? Thanks!...

My Guix build: ``` aarch64 fba7e542bc6a35c65a179f9c8cd3ae2b0f8b12cd5895fa255a2d344d576d0215 guix-build-915640e191b6/output/aarch64-linux-gnu/SHA256SUMS.part c9c1d47120de9a45aa5da1c17cc8f4860f2268bfe413d38e1b6f67ea96bd4f09 guix-build-915640e191b6/output/aarch64-linux-gnu/bitcoin-915640e191b6-aarch64-linux-gnu-debug.tar.gz c1775debe30e5a28d981720582c5e6f36ea33939169a429edc48c4bb8ebc3688 guix-build-915640e191b6/output/aarch64-linux-gnu/bitcoin-915640e191b6-aarch64-linux-gnu.tar.gz 870a9d4f46ec2906a7d22d904eb53a8d372ce06fe727983a9aadcfe1dbdcc321 guix-build-915640e191b6/output/arm-linux-gnueabihf/SHA256SUMS.part fb49bbbb404986f23ad231033c07588e2e612960da7da7dcdfcde9b21e3fb7b0 guix-build-915640e191b6/output/arm-linux-gnueabihf/bitcoin-915640e191b6-arm-linux-gnueabihf-debug.tar.gz 07e03402e62f4b9684342563ce40508342c429c546aeecd805a2a1bf645af7a2 guix-build-915640e191b6/output/arm-linux-gnueabihf/bitcoin-915640e191b6-arm-linux-gnueabihf.tar.gz bddeb0bbd99b437406092f4af1fa630740e20d5e6277982a7858fa22fd245c0a guix-build-915640e191b6/output/arm64-apple-darwin/SHA256SUMS.part 8ddb3b97ff42eecbe27339b1cd8b048273638958f2b68fea4dddff8d28755cd3 guix-build-915640e191b6/output/arm64-apple-darwin/bitcoin-915640e191b6-arm64-apple-darwin-unsigned.tar.gz 78768d58a16d254b27921c4712ef810254bbc206eab72393e9f96661408bdd72 guix-build-915640e191b6/output/arm64-apple-darwin/bitcoin-915640e191b6-arm64-apple-darwin-unsigned.zip 8849c895be879bc199f4f6a3a355e7fdddc67a58e7382c6e930efffb55a43bf8 guix-build-915640e191b6/output/arm64-apple-darwin/bitcoin-915640e191b6-arm64-apple-darwin.tar.gz 24f2fc6a1e2bea8f0ac8e0fe8d566432e7b45d2e26f7367c57ae4230f8fa50e5 guix-build-915640e191b6/output/dist-archive/bitcoin-915640e191b6.tar.gz 067b2cd3e9aaca53592fa87aff972b776d9cf86264cf0ed2dfa40b0fc79492ac guix-build-915640e191b6/output/powerpc64-linux-gnu/SHA256SUMS.part 7fb4f4b24affe6983da95c679ec457ba672e2761757e746eb62aa86dc11ba544...

> We should also follow up with refactoring the libevent module, to more generically use CMake/pkg-config, rather than restricting the CMake usage to `vcpkg`. At that point, we'd likely be...

Also see: - https://github.com/bitcoin-core/gui-qml/pull/454#issuecomment-2896780300 - https://github.com/bitcoin-core/gui-qml/pull/454#issuecomment-2902060347

Also see https://github.com/bitcoin/bitcoin/pull/29678.