Alex Zaytsev comments

Results 418 comments of


                                            Alex Zaytsev

Expressions in the ORDER BY list cannot contain aggregate functions.

This depends on your DB. Solution would likely be to order in memory.

Expressions in the ORDER BY list cannot contain aggregate functions.

You're welcome to submit a PR with fixes. The problem is with your RDBMS dialect that does not support this: other RDBMS do support the SQL generated by NHibernate in...

Encourage use of .NET 9.0's System.Threading.Lock

Thanks for the contribution. It is unlikely we'll be targeting .NET 9 version as it is not LTS. Also, we would like to avoid an external dependency.

LINQ uses ternary expressions to generate error SQL

> under NET8 Does it work correctly with lower versions?

Replace github.com/pkg/errors with stdlib

/remove-lifecycle stale

Replace github.com/pkg/errors with stdlib

/remove-lifecycle stale

Micro optimization: Eliminate memory allocations in GuidCombGenerator under .NET 8+

What is performance gain here?

Micro optimization: Eliminate memory allocations in GuidCombGenerator under .NET 8+

I would just go with this implementation: ```csharp protected static Guid GenerateComb(Guid guid, DateTime utcNow) { #if NETSTANDARD2_1_OR_GREATER || NETCOREAPP2_1_OR_GREATER Span guidArray = stackalloc byte[16]; guid.TryWriteBytes(guidArray); #else var guidArray =...

AbstractDateTimeType.Round is a Floor not a Round

I think this was intentional. I don't think it is semantically correct to round time up, because it potentially could produce a future time.

Proposition for Unit tests more fluent syntax

Looks good. Thanks.