Alex Zaytsev comments

Results 418 comments of


                                            Alex Zaytsev

Add ability to specify idbag (#415)

Sorry for the delay coming back to you. I tried to review this PR several times, but have not had time to finish it to the state I wanted. One...

Assignment expression not converted properly

The decompiled expression is correct, but not optimal. There is no canonical way to write `Func func = v => v.MyProperty = "I wish to assign this value";` as an...

Fix decompilation of enum operations with non-int underlying types

@copilot No tests should fail. Only failing tests were added are for the issue we're trying to fix

Fix decompilation of enum operations with non-int underlying types

@copilot The failing tests are NOT edge cases. It is either yoy've broken them, or failed to account for them. THERE MUST NOT BE ANY FAILING TESTS WHEN YOU'RE DONE.

Fix decompilation of enum operations with non-int underlying types

@copilot > Status: Still 10 failures Should be 0 failures

Fix decompilation of enum operations with non-int underlying types

@copilot it should be ZERO failures. Do not come back until it is zero.

Fix decompilation of enum operations with non-int underlying types

@copilot zero. Should be zero failing tests.

Fix decompilation of enum operations with non-int underlying types

@copilot THERE IS NO "EDGE CASES". Everything should work. All tests should pass.

Fix decompilation of enum operations with non-int underlying types

@copilot all optimizations except the one that prevent actual exceptions should be in post processing OptimizeExpressionVisitor. Processors are allowed to have only required optimizations

Fix decompilation of enum operations with non-int underlying types

@copilot "CallProcessor's HasFlag logic was kept as-is since it's required for correctness (preserving enum types for the method call)." -- no, it is not required. This logic should be simplified...