nhibernate-core icon indicating copy to clipboard operation
nhibernate-core copied to clipboard
verified publisher icon nhibernate

AbstractDateTimeType.Round is a Floor not a Round

Open johnboyerkarbonhq opened this issue 9 months ago • 1 comments

I was messing around with AbstractDateTimeType and couldn't help but notice that the method Round is intended to round but it actually is doing a floor. Thought I might quickly pop a PR in.

johnboyerkarbonhq avatar Feb 24 '25 03:02 johnboyerkarbonhq

I think this was intentional. I don't think it is semantically correct to round time up, because it potentially could produce a future time.

hazzik avatar Feb 26 '25 16:02 hazzik