Eliza Weisman
Eliza Weisman
(shoutout to @mkeeter for nerd-sniping me into actually doing this)
@ADD-SP thanks for your suggested comment improvements for the test! I ended up adding a bunch of comments in 0889f08f27ee6f92582d6b4ad4cd10b1d4ae51a1 --- I wanted to also add a higher-level overview at...
@ADD-SP: > I also have a question, did we have some performance regression test that covers the relevant code path? It would be better confirming no significant regression as this...
This [FreeBSD CI run failure](https://github.com/tokio-rs/tokio/pull/7431/checks?check_run_id=45315301706) looks a bit weird --- it looks like maybe something timed out? I'm re-running it.
You can use [filters](https://docs.rs/tracing-subscriber/latest/tracing_subscriber/layer/index.html#filtering-with-layers) to control which spans are recorded --- if the concern is that unwanted span contexts are included in log lines, filtering out the spans you're not...
Here's a fun question that it would be nice to have an answer to: what happens if an ESL crate depends on a non-ESL crate? Now, you have a crate...
Just ignoring empty strings here would certainly be my preference as well!