Eliza Weisman
Eliza Weisman
"Obvious solution" to the "Bingrep is not GREP" problem: keep the name, but it's pronounced "bing-rep". ;)
@KodrAus thanks, this is great! I've wanted to open a ticket for discussing this work for a while. > Since `tracing` already makes some concessions to `log` support (by handling...
> so I just made the PR for v0.1.x, and then no one complained/told me to make it on master... (: i wasn't paying attention, sorry. :) i'm fine with...
Okay, I've made some additional changes to this branch and the performance regression is now...less severe: ``` Switched to branch 'fix-logging-with-interest-cache' Your branch is up to date with 'origin/fix-logging-with-interest-cache'. Compiling...
> @hawkw how do we want to move forward? I would like to reduce the performance regression in the `dispatch/get_ref` benchmark a bit more (+63% is not as bad as...
Whoops, we were actually not running the benchmarks with a global default subscriber (:upside_down_face:). After fixing that (in 181bdbe1d8f6222aaff6dea17267d0779d07caf3), we see that the perf diff in that case is more...
@bkchr thanks for continuing to work on this, I'm excited to take a look at your recent changes.
@bkchr just to clarify, are change percentages in the benchmark results you posted in https://github.com/tokio-rs/tracing/pull/2165#issuecomment-1231420625 relative to `v0.1.x`, or to a previous state of this branch?
Fantastic, thanks!
> Note: > > Is it possible to provide a UI test (like https://github.com/dtolnay/trybuild) for tracing macros? Otherwise, any recommendations on how to provide a test for this change, since...