Eliza Weisman

Hmm, that doesn't seem right. The guard returned by `Span::enter` should call the span's `do_exit()` method when it's dropped: https://github.com/tokio-rs/tracing/blob/bfca5460e1c56daf663ffad8f8de6aa3d21f8685/tracing/src/span.rs#L1558-L1570 The `Span::do_exit()` method calls `exit` on the subscriber that was...

Looking at the panic in hyperium/hyper#3848, I see that and the stack indicates that we are in the span's `try_close` method: ``` stack backtrace: 0: rust_begin_unwind at /rustc/4d91de4e48198da2e33413efdcd9cd2cc0c46688/library/std/src/panicking.rs:692:5 1: core::panicking::panic_fmt...

The plan is that in `tracing-attributes` v0.2, fields in `instrument` will be opt-in rather than opt-out. Since #672 added support for arbitrary expressions as fields to `instrument`, you will be...

I think it's quite reasonable to make the `make_writer()` call a _guaranteed_ boundary for the log record. It certainly has that semantics now, and I think we can safely make...

Whoops, good catch! Should be a trivial fix.

We should probably consider moving to `doc-auto-cfg` where possible so we don't have problems with missing cfg attributes

looks like `cargo fmt` needs to be run on this PR: https://github.com/tokio-rs/tracing/actions/runs/5900755392/job/16019086920?pr=2316

It's worth noting that if `lock()` is changed to always panic on poisoning at an edition boundary, it should probably only do so if `!std::thread::panicking()`; I've seen plenty of code...

Hi, sorry I missed this one! I think something like this would be great — there are a lot of deficiencies with the `fmt::Json` subscriber that could be solved by...

You may need to patch `reqwest` and `hyper`'s `tokio` dependency?