Eliza Weisman
Eliza Weisman
> LGTM, thanks! Will just wait till that socket2 release :) Yup, no rush --- just wanted to get this ready to go when that's out. :)
Haha, I was just about to leave a comment mentioning that the `socket2` release had been published --- impressive reaction time, @seanmonstar! :)
> I would be happy to see CI running for Illumos. Since this will end up using a new service for running the CI jobs, please include a readme with...
Ah, I had missed this, thanks @Darksonn! Interestingly, on illumos, `try_with_interest`, `try_io`, and `reset_readable` pass, but `reset_writable` and `poll_fns` seem to run forever, as reported here. I believe the difference...
> > Same error, but it has changed name between 0.1 and 0.2, so not clear if one can include this in the 0.3-series... > > From a quick glance,...
Yeah, the current `FormatEvent` interface could use some work. I'd like to prioritize improving this as part of the upcoming `tracing-subscriber` 0.3 release.
@dvdplm thanks for the offer! Right now, I think we mostly need to answer some API design questions --- what do we need to add, and what do we need...
I'm a little wary of making too much of the current interface `pub` --- then, it becomes a breaking change to remove it in the future. Rather than making `FmtContext`...
> > Last lastly: to be honest --but not entirely related to this issue-- we also encountered an issue with the key-value thingy in the span macros. They allow a...
Changes like #1651 may be helpful here as well.