Eliza Weisman comments

Results 637 comments of


                                            Eliza Weisman

chore(deps): bump ratatui to 0.26.2 and crossterm to 0.27.0

@joshka mind rebasing this branch onto the latest `master` and resolving the lockfile conflicts? Once that's done, this should be good to merge!

Console doesn't detect self wakes from `tokio::task::yield_now()` after Tokio 1.23

~~Hmm, do we know why the wake operation is no longer inside the task's span? What changed upstream in `tokio` that resulted in the task span being exited before the...

Console doesn't detect self wakes from `tokio::task::yield_now()` after Tokio 1.23

Thinking about this...I honestly think it _might_ be okay to just exclude `task::yield_now()` from the self-wake warning, _because_ of the changes in tokio-rs/tokio#5223. The primary reason we want to warn...

Console doesn't detect self wakes from `tokio::task::yield_now()` after Tokio 1.23

Sounds good to me, thanks for flagging this!

chore(deps): bump tokio from 1.21.0 to 1.24.2

@dependabot rebase

chore(deps): bump tokio from 1.21.0 to 1.24.2

@dependabot recreate

Key presses happen twice on Windows

Interesting, thanks for the report! I wonder if there's something we can enable in `crossterm`/`ratatui` to make its key event behavior on Windows consistent with other platforms? If not, we...

Provide API to embed text console

It would definitely be possible to expose a library API to allow embedding the `tokio-console` TUI in another binary --- and probably fairly straightforward. We mostly haven't done this yet...

use HeaderName::from_static in Send::check_headers

re-approved, hopefully everything passes this time!

Use span without a parent for connection

Sorry, I was traveling for the last couple weeks. I'll take a look!