Weizhen Wang

Results 100 comments of Weizhen Wang

OK,let me research it. > I think calculate checksum field by field is not very elegant because we may need to add more fields later. Checksum a whole chunk of...

Thank you for your suggestion. I have started to use ```https://github.com/golang/exp/tree/master/slices ``` to implement [it](https://github.com/pingcap/tidb/pull/34404).

It still has some code collecting the monitoring from Prometheus. If we don't use Prometheus,the old branch will be deleted.

We have meet this problem, too. but we are not main package. https://github.com/pingcap/tidb/pull/37413 https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_build/detail/tidb_ghpr_build/78196/pipeline ``` util/texttree/texttree.go:15:1: package-comments: should have a package comment (revive) ``` https://github.com/pingcap/tidb/blob/a80078538d366d55acfc34dd772b1977a720a9bc/util/texttree/texttree.go#L14-L16

@cfzjywxk PTAL ``` [2022-09-23T09:44:19.618Z] planner/core/integration_test.go:19: File is not `goimports`-ed (goimports) [2022-09-23T09:44:19.618Z] "fmt" ```

``` ================== WARNING: DATA RACE Write at 0x00c00296d930 by goroutine 144078: github.com/pingcap/tidb/ddl_test.TestCancel.func3() ddl/cancel_test.go:287 +0x84 github.com/pingcap/tidb/ddl_test.TestCancel() ddl/cancel_test.go:303 +0xaed testing.tRunner() GOROOT/src/testing/testing.go:1446 +0x216 testing.(*T).Run.func1() GOROOT/src/testing/testing.go:1493 +0x47 Previous read at 0x00c00296d930 by goroutine 173305:...