risinglight icon indicating copy to clipboard operation
risinglight copied to clipboard

Published 20 hours ago • verified publisher icon risinglightdb

storage: checksum `BlockType` in block header

Open skyzh opened this issue 2 years ago • 2 comments

Currently, we store the BlockType in header of each block. Therefore, this part is not checksumed. We should get this part checksumed.

skyzh avatar Dec 20 '21 05:12 skyzh

Let me have a try!

hawkingrei avatar Jan 29 '22 06:01 hawkingrei

Thanks! The core logic lies in

https://github.com/risinglightdb/risinglight/blob/141a2624a527e346900a8c2d185d8176c89e460d/src/storage/secondary/block/block_index_builder.rs#L62-L75

I think we may need to change the encoding of block headers (e.g., put block type and checksum at the end?) in order to support this.

skyzh avatar Jan 29 '22 06:01 skyzh

Hi, I found that the previous PR https://github.com/risinglightdb/risinglight/pull/544 has not make progress in about half a year, so I'd like to take a try.

unconsolable avatar Oct 06 '22 14:10 unconsolable