tidb
tidb copied to clipboard
*: Always generate global stats for partitioned tables
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
Always generate global statistics for partitioned tables.
Reverts the PR that falls back on static prune mode if global statistics does not exist.
What is changed and how it works?
Check List
Tests
- [x] Unit test
- [x] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No code
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
Always generate global/table level statistics for partitioned tables, regardless of the tidb_partition_prune_mode setting.
[REVIEW NOTIFICATION]
This pull request has not been approved.
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer
in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer
in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
/run-unit-test
/run-unit-test
/run-mysql-test tidb-test=pr/1975
/run-mysql-test tidb-test=pr/1975
/run-mysql-test tidb-test=pr/1975
/run-mysql-test tidb-test=pr/1975
/run-mysql-test tidb-test=pr/1975
/run-check_dev_2
/run-mysql-test tidb-test=pr/1975
@mjonss: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@mjonss: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
idc-jenkins-ci-tidb/check_dev_2 | 2109f695d8eed1ad289948f41c21eff7486803bd | link | true | /test check-dev2 |
idc-jenkins-ci-tidb/mysql-test | 2109f695d8eed1ad289948f41c21eff7486803bd | link | true | /test mysql-test |
idc-jenkins-ci-tidb/check_dev | 2109f695d8eed1ad289948f41c21eff7486803bd | link | true | /test check-dev |
idc-jenkins-ci-tidb/build | 2109f695d8eed1ad289948f41c21eff7486803bd | link | true | /test build |
idc-jenkins-ci-tidb/unit-test | 2109f695d8eed1ad289948f41c21eff7486803bd | link | true | /test unit-test |
pull-mysql-client-test | 2109f695d8eed1ad289948f41c21eff7486803bd | link | true | /test pull-mysql-client-test |
pull-integration-ddl-test | 2109f695d8eed1ad289948f41c21eff7486803bd | link | true | /test pull-integration-ddl-test |
pull-br-integration-test | 2109f695d8eed1ad289948f41c21eff7486803bd | link | true | /test pull-br-integration-test |
pull-lightning-integration-test | 2109f695d8eed1ad289948f41c21eff7486803bd | link | true | /test pull-lightning-integration-test |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.