tidb icon indicating copy to clipboard operation
tidb copied to clipboard

*: Always generate global stats for partitioned tables

Open mjonss opened this issue 1 year ago • 9 comments

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

Always generate global statistics for partitioned tables.

Reverts the PR that falls back on static prune mode if global statistics does not exist.

What is changed and how it works?

Check List

Tests

  • [x] Unit test
  • [x] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No code

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Always generate global/table level statistics for partitioned tables, regardless of the tidb_partition_prune_mode setting.

mjonss avatar Sep 14 '22 15:09 mjonss

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Sep 14 '22 15:09 ti-chi-bot

/run-unit-test

mjonss avatar Sep 16 '22 10:09 mjonss

/run-unit-test

hawkingrei avatar Sep 17 '22 02:09 hawkingrei

/run-mysql-test tidb-test=pr/1975

mjonss avatar Sep 19 '22 08:09 mjonss

/run-mysql-test tidb-test=pr/1975

mjonss avatar Sep 19 '22 08:09 mjonss

/run-mysql-test tidb-test=pr/1975

mjonss avatar Sep 19 '22 08:09 mjonss

/run-mysql-test tidb-test=pr/1975

mjonss avatar Sep 19 '22 10:09 mjonss

/run-mysql-test tidb-test=pr/1975

mjonss avatar Sep 19 '22 10:09 mjonss

/run-check_dev_2

mjonss avatar Sep 21 '22 08:09 mjonss

/run-mysql-test tidb-test=pr/1975

mjonss avatar Sep 28 '22 15:09 mjonss

@mjonss: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot avatar Oct 22 '22 09:10 ti-chi-bot

@mjonss: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 2109f695d8eed1ad289948f41c21eff7486803bd link true /test check-dev2
idc-jenkins-ci-tidb/mysql-test 2109f695d8eed1ad289948f41c21eff7486803bd link true /test mysql-test
idc-jenkins-ci-tidb/check_dev 2109f695d8eed1ad289948f41c21eff7486803bd link true /test check-dev
idc-jenkins-ci-tidb/build 2109f695d8eed1ad289948f41c21eff7486803bd link true /test build
idc-jenkins-ci-tidb/unit-test 2109f695d8eed1ad289948f41c21eff7486803bd link true /test unit-test
pull-mysql-client-test 2109f695d8eed1ad289948f41c21eff7486803bd link true /test pull-mysql-client-test
pull-integration-ddl-test 2109f695d8eed1ad289948f41c21eff7486803bd link true /test pull-integration-ddl-test
pull-br-integration-test 2109f695d8eed1ad289948f41c21eff7486803bd link true /test pull-br-integration-test
pull-lightning-integration-test 2109f695d8eed1ad289948f41c21eff7486803bd link true /test pull-lightning-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Apr 10 '24 10:04 ti-chi-bot[bot]