Shantanu

Results 383 comments of Shantanu

mypy_primer runs in like 8m on typeshed and that's with a much larger set of projects than you'd need. > increase the time it takes to review PRs because if...

Something like that sounds interesting. You're right that making sure we check out the same versions of all the projects is the important detail to get right. Will also have...

Thanks for investigating! I just removed it for now in https://github.com/hauntsaninja/mypy_primer/commit/d1263e0c5f4552c13c0449b62ba0dc8e4167a0bd , can figure out if we should change clone or something later

I'd added a `--new-mypypath` and `--old-mypypath` for this kind of use case. It lets you put different things on MYPYPATH for the "new" run and the "old" run. MYPYPATH can...

Thanks, yeah, running more stuff in CI is a good idea, but I'm not sure what exactly. When adding or changing projects, the thing that is most valuable is the...

https://github.com/hauntsaninja/mypy_primer/pull/28#issuecomment-1017211613 is a good example of needing to see the full output to know things are broken :-)

It looks like pip forces recompilation too, and this goes back to pip v1.5 https://github.com/pypa/pip/commit/7ec49dc2fb0a9dbf522e79d87e2bc13d29a2556e#diff-9b28941fa609b0277432cba3444d4595da4ef80ca7c04e9024c75bb0a15ae830R163 Couldn't discern a reason for that, but since it's only doing it for the newly...

Yeah, probably. I just tested my first suggestion since it's easy: ``` diff --git a/crates/uv-installer/src/pip_compileall.py b/crates/uv-installer/src/pip_compileall.py index 47e0242f..20bb3c6e 100644 --- a/crates/uv-installer/src/pip_compileall.py +++ b/crates/uv-installer/src/pip_compileall.py @@ -47,7 +47,7 @@ with warnings.catch_warnings(): #...

Since this issue is somewhat popular, just noting that I've been doing `VIRTUAL_ENV=$(python -c "import sys; print(sys.prefix)") uv pip ...`

Fixing the stubtest issue...