mypy_primer icon indicating copy to clipboard operation
mypy_primer copied to clipboard

Published 20 hours ago • verified publisher icon hauntsaninja

Run `mypy_primer` on pull requests

Open sobolevn opened this issue 2 years ago • 2 comments

I guess that it is a good idea to run priper, when the source code changes. This might catch possible regressions in the future.

sobolevn avatar Jan 20 '22 06:01 sobolevn

Thanks, yeah, running more stuff in CI is a good idea, but I'm not sure what exactly.

When adding or changing projects, the thing that is most valuable is the "full" output (you need the full output because e.g. if you misconfigure and there's zero output, the diff is also zero). But "full" output is very verbose across all 100 projects — maybe we need a primer for primer output :-)

For what it's worth, I usually just test locally with mypy_primer -k new_project --debug.

hauntsaninja avatar Jan 20 '22 07:01 hauntsaninja

https://github.com/hauntsaninja/mypy_primer/pull/28#issuecomment-1017211613 is a good example of needing to see the full output to know things are broken :-)

hauntsaninja avatar Jan 20 '22 08:01 hauntsaninja