Shantanu

Results 383 comments of Shantanu

Looks like callback protocol support hurts overloads more than previously. Probably need to improve `extract_callable_type`

Closing since this is stale and isn't passing tests, please feel free to re-open if you get time to get it working! :-)

Any chance you can make a shareable repro? E.g. try removing stuff from the file until you get something small enough to redact that mypy still crashes on. Also worth...

What if you keep `@declared_mixin`, but remove `plugins = "sqlalchemy.ext.mypy.plugin"` from your mypy configuration?

It seems like this might be specific to `sqlalchemy.ext.mypy.plugin`, in which case you might be better off reporting to that project. They're probably also going to ask for a repro...

I think mypy is correct to complain about https://github.com/python/mypy/issues/15620#issuecomment-1625688906 ; pyright does as well. `check_passwords_match` does not have the right return type in the presence of `UserModel` subclasses. If you...

I'm not sure exactly I understand, but in pydantic case I think you can try a `self: BaseModel` annotation

I merged your cherry pick, but it looks like the tag was already made. We'll see what happens, worst case we can do a 1.5.1