Piotr Monwid-Olechnowicz

Results 140 comments of Piotr Monwid-Olechnowicz

@nandorojo the Stitches PR I mentioned in Twitter DMs. https://github.com/modulz/stitches/pull/206 Our code and tests will end up looking pretty similar I suppose.

> @hasparus The scales are all complete. Mind looking over them? Getting right to it today / tomorrow morning.

I'm annotating the scales with `Record` to ensure we don't miss anything. ```tsx const sizes: Record = {} ```

yup, I think so. I’m pretty excited about how it's starting to look. I'd also like to get deep paths in scales to make the "strict mode" compatible with all...

> If so, is there an easy way to extend the sx prop? I think we can use declaration merging for that. I'll try that and send you a snippet.

@nandorojo @lachlanjc would you have a moment to give this PR another look? @beerose you promised me code review. There should be no breaking changes at runtime, and I think...

This is intended, but the naming is kinda misleading here here. There are four providers here if we wanted to name them in a more self-explanatory manner. 1. `ThemeUIThemeProvider` in...

How could we help with this problem? @ackwell, do you feel like `@theme-ui/core` should be documented more thoroughly? How did you encounter the problem?

Thanks for the explanation, ackwell! Yup, I can see how it's confusing now. Okay, I think we can do a few things - [ ] Rename ThemeProvider in cover to...

> @hasparus out of interest, why did you unpin this issue? By accident. Thank you. Let's keep this one pinned.